---
id: TASK-3.3
title: Fix clippy issues in core/config tests
status: Done
assignee: []
created_date: '2026-02-23 19:31'
updated_date: '2026-02-23 19:36'
labels:
  - lint
  - tests
dependencies: []
references:
  - src/core/config.rs
parent_task_id: TASK-3
---

## Description

<!-- SECTION:DESCRIPTION:BEGIN -->
Resolve clippy warnings in core/config tests (field_reassign_with_default, redundant closure, unwrap_used) by adjusting setup and assertions.
<!-- SECTION:DESCRIPTION:END -->

## Acceptance Criteria
<!-- AC:BEGIN -->
- [x] #1 Core/config tests no longer trigger field_reassign_with_default, redundant_closure_for_method_calls, or unwrap_used warnings.
- [x] #2 Tests still cover the same behaviors and remain hermetic.
<!-- AC:END -->

## Implementation Plan

<!-- SECTION:PLAN:BEGIN -->
1) Update core/config test setup to avoid `field_reassign_with_default` by constructing `FileConfig` with struct update syntax.
2) Replace `all(|r| r.is_ok())` with `all(Result::is_ok)`.
3) Replace `unwrap()` on parent paths with `expect()` and/or precompute the expected path safely.
4) Run `just check` to confirm warnings are cleared.
<!-- SECTION:PLAN:END -->

## Implementation Notes

<!-- SECTION:NOTES:BEGIN -->
Plan approved by user on 2026-02-23.

Updated core/config tests to use struct update syntax, replaced redundant closure with `Result::is_ok`, and replaced unwraps with expect in Zephyr env test. Remaining clippy issues are in config/schema tests.
<!-- SECTION:NOTES:END -->
